Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duplicate key error in Privacy and Settings #11663

Closed
wants to merge 1 commit into from

Conversation

gambinish
Copy link
Contributor

Description

ERROR  Warning: Encountered two children with the same key, `0x89`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.

Related issues

Fixes: No issue, found while developing

Manual testing steps

  1. Add Polygon, and add a custom RPC Polygon
  2. Go to Network Settings
  3. Should not see duplicate key error in logs

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ate nickname-chainId to reduce this possibility
Copy link
Contributor

github-actions bot commented Oct 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title fix: Setting and Privacy network list can have duplicate chainId, cre… fix: Duplicate key error in Privacy and Settings Oct 7, 2024
@gambinish gambinish closed this Oct 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant